Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
misc:acpi_patch [2025/04/28 15:20] – 92.40.46.204misc:acpi_patch [2025/12/13 12:10] (current) – rqm
Line 1: Line 1:
 ====== The Dreaded ACPI Timeout Bug ====== ====== The Dreaded ACPI Timeout Bug ======
 +
 +----
 +===== ⚠️ IMPORTANT =====
 +
 +As of  Sun Nov 23 19:56:24 2025 this bug has been [[https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/dev/acpi/dsdt.c?ipk=o-qnntKcxllUqcGWG9W-C-riLyb0POvhyp3hLhnaFy4|fixed in OpenBSD 7.8-current]], and so it will be fixed in the OpenBSD 7.9-stable release.  
 +
 +Therefore **THE LAST OpenBSD 7.8-stable build [[https://mirror.openbsdonapple.wiki/pub/OpenBSD/7.8/amd64/|provided on our mirror]] with the below ACPI patch will be the one built on 2025-12-07,** incorporating OpenBSD 7.8 errata patches no. 001-011.
 +
 +**USERS AFFECTED BY THIS ARE ADVISED TO UPGRADE TO 7.8-current by grabbing a [[https://ftp.openbsd.org/pub/OpenBSD/snapshots/amd64/|snapshot installer]] or running** `sysupgrade -s`, and when it is released in 2026, upgrade to OpenBSD 7.9.
 +----
 +
 +===== The ACPI bug =====
  
 Some models can experience really, really long boot times with OpenBSD. This bug has been known for a while and seems to have appeared around OpenBSD 7.6. It has [[https://bsd.network/@brynet/114322673716285788|featured]] [[https://old.reddit.com/r/openbsd/comments/1ixz0bn/macbook_2015/|in]] [[https://marc.info/?l=openbsd-bugs&m=173855804823166&w=2|a lot of]] [[https://marc.info/?l=openbsd-misc&m=174438934730598&w=2|discussions]], and resolving it caused so much unbridled joy that it prompted the creation of this entire wiki. Some models can experience really, really long boot times with OpenBSD. This bug has been known for a while and seems to have appeared around OpenBSD 7.6. It has [[https://bsd.network/@brynet/114322673716285788|featured]] [[https://old.reddit.com/r/openbsd/comments/1ixz0bn/macbook_2015/|in]] [[https://marc.info/?l=openbsd-bugs&m=173855804823166&w=2|a lot of]] [[https://marc.info/?l=openbsd-misc&m=174438934730598&w=2|discussions]], and resolving it caused so much unbridled joy that it prompted the creation of this entire wiki.
 +
  
 ===== The Symptoms ===== ===== The Symptoms =====
Line 14: Line 27:
 ===== Affected Models ===== ===== Affected Models =====
   * [[:A1502]] Early 2015 Macbook Pro   * [[:A1502]] Early 2015 Macbook Pro
-  * Maybe others?+  * [[:A1466]] Macbook Air ([[https://marc.info/?l=openbsd-misc&m=176103403030425&w=2|reported on misc@)]] 
 +  * [[:A1465]] Early 2015 Macbook Air ([[https://marc.info/?l=openbsd-misc&m=176115553125606&w=2|reported on misc@]]) 
 + 
 +==== Lazy way to fix the ACPI bug ==== 
 + 
 +We've prepared a custom image that contains the ACPI patch. If you trust us enough (hint: you shouldn't) then you may grab the installer and sets here: 
 + 
 +https://mirror.openbsdonapple.wiki/pub/OpenBSD/7.8/amd64/
  
 ==== Patch to fix the ACPI bug ==== ==== Patch to fix the ACPI bug ====
  
-<code> +**Download links:** 
-Index: sys/dev/acpi/acpi.c +  * For OpenBSD 7.7 {{ :misc:macbook-acpi-patch-77.tar.gz |macbook-acpi-patch-77.tar.gz}} 
-=================================================================== +  * For OpenBSD 7.8 {{ :misc:macbook-acpi-patch-78.tar.gz |macbook-acpi-patch-78.tar.gz}}
-RCS file: /cvs/src/sys/dev/acpi/acpi.c,v +
-diff -u -p -u -r1.444 acpi.c +
---- sys/dev/acpi/acpi.c 24 Mar 2025 09:53:20 -0000 1.444 +
-+++ sys/dev/acpi/acpi.c 20 Apr 2025 19:45:13 -0000 +
-@@ -823,8 +823,8 @@ acpi_pci_set_powerstate(pci_chipset_tag_ +
-  } +
- #endif /* NACPIPWRRES > 0 */ +
-  +
-- if (state == ACPI_STATE_D0 && pre) +
-- aml_evalname(sc, pdev->node, "_PS0", 0, NULL, NULL); +
-+// if (state == ACPI_STATE_D0 && pre) +
-+// aml_evalname(sc, pdev->node, "_PS0", 0, NULL, NULL); +
- } +
-  +
- int +
-</code>+
  
 ==== How to patch ==== ==== How to patch ====
Line 104: Line 108:
  
 After you reboot, the new kernel should be the one in use. It will be easy to tell whether the patch worked, because if your system boots "normally", it worked, if you are back at waiting for 2+ hours at "sd0", it failed and you need to check over whether you did everything correctly. After you reboot, the new kernel should be the one in use. It will be easy to tell whether the patch worked, because if your system boots "normally", it worked, if you are back at waiting for 2+ hours at "sd0", it failed and you need to check over whether you did everything correctly.
 +
  
 ---- ----
-=== II. The Custom Installer Way === 
  
-Creating a custom installer requires you to have another amd64 machine running OpenBSD. You will be able to build the kernel at the version your OpenBSD machine is already on. You need to make sure you are fetching the appropriate version of the sources, like above.  
  
-The procedure, in short, involves building the custom GENERIC.MP image as well as a custom RAMDISK, but WITHOUT running ''make install'' at the end. Then you create a ''vnode'' device out of the downloaded ''installXX.img'', mount it, then overwrite the installer's {bsd,bsd.mp,bsd.rd} files with the ones you created.+===== Updating the patched system ===== 
 +If you want to avoid having to wait 2+ hours again TWICE everytime you have to update your system, there is, fortunately, a much quicker way to do it. Basically the less painfully slow update method is a hybrid of manual and automatic installation with custom-compiling the kernel. Credits go to [[https://marc.info/?l=openbsd-tech&m=175031825008339&w=2|Stuart Henderson]] for pointing out this possibility.
  
-== 0. Preliminaries ==+The below will be a walkthrough that follows ''-current'', a few commands will be different for ''-stable'', these will be indicated.
  
-You will also need a copy of ''installXX.img'' and a flash drive. (Some Macs cannot boot off an SD card so best to stick with USB flash drives).+==== 0. Preparation ==== 
 +=== 0.a. READ UP. Seriously. === 
 +Read through the [[https://www.openbsd.org/faq/upgrade77.html#NoInstKern|OpenBSD Manual Installation howto in the FAQ]] first as well as the man pages linked above, if you have not done so. They will make your life much much easier.
  
-If you are on ''-current'' then you need to make sure that the installer you download corresponds to the snapshot you are on. To see what version exactly you are on, run: +=== 0.b. Preparation === 
-<code> +Follow the "Preparation" steps on the Manual Upgrade page: especially on becoming root "properly" and installing the boot blocks. Make sure you install the boot blocks to the appropriate drive, do not just go with "sd0" as it was in the tutorial, if, say your root is on e.g. sd3.
-$ sysctl kern.version +
-kern.version=OpenBSD 7.7-current (GENERIC.MP) #0: Wed Apr 23 20:21:10 BST 2025 +
-    [..snip..] +
-</code>+
  
-Note the date; in the above example, it's **"Apr 23 2025"**, so you need the installXX.img from that same snapshot - as it's on **7.7-current** it will be ''install77.img''. +==== 1. Get the upgrade files ==== 
- +Fetch the updates and move them to a new location. When you run ''sysupgrade'' the installer files are stored in ''/home/_sysupgrade'', and two extra files are created, ''/bsd.update'' and ''/auto_upgrade.conf''. You want to copy the installer files from ''/home/_sysupgrade'' somewhere else, and delete the auto-update files.
-A good place to get previous snapshots is on ''ftp://ftp.hostserver.de/archive/'', choosing the ''YYYY-MM-DD-HHSS'' format directory that corresponds to the date of your ''kern.version'' date; so in this example, the file needed would be at: +
- +
-''%%https://ftp.hostserver.de/archive/%%**2025-04-23-0105**/snapshots/amd64/**install77.img**'' +
- +
-==== Upgrading your system after patching ==== +
-Should a new release come out, unless there's a rewrite of ''acpi.c'', you will need to re-patch your kernel upon upgrade. +
- +
-On your working, normally booting system, you need to patch in place like with "The Slow Boot Way" above. +
- +
-First, you need to **follow the "anoncvs" tutorial on the OpenBSD website and upgrade the source tree.** +
- +
-When updating it will skip "acpi.c" because you have manually changed the file locally. Overwrite the local changes by running:+
 <code> <code>
-# cd /usr/src/sys/dev/acpi/ +# sysupgrade -ns 
-# cvs update -C acpi.c+# mkdir /usr/update 
 +# mv /home/_sysupgrade/* /usr/update/ 
 +# rm /{bsd.update,auto_upgrade.conf}
 </code> </code>
 +**NB**: On ''-stable'' you want to run ''sysupgrade -n''.
  
-This will then move your own version of ''acpi.c'' to a hidden backup file, something like ''.#acpi.c.1.444'' or similar, keep a note of the command output. Run a diff on the freshly fetched acpi.c and the one you had:+==== 2. Update the source tree ==== 
 +Follow the **Anonymous CVS** guides for updating the source tree to the latest version.  
 +☛ **ASIDE** - What to do if acpi.c changes drastically and the patch doesn't work anymore? ((The file we have been patching, ''/usr/src/sys/dev/acpi/acpi.c'', might change in the future. It is good to check the CVS logs, or keep an eye on the [[https://github.com/openbsd/src/commits/master/sys/dev/acpi/acpi.c|acpi.c on GitHub's CVS mirror]].  If you would see that the lines we have been working with have changed in the source or new features have been introduced, then you need to revert your local modifications to the CVS version. To do this, you need to run,
 <code> <code>
-# diff acpi.c .#acpi.c.1.444+$ cd /usr/src/sys/dev/acpi/ 
 +$ cvs update -C acpi.c
 </code> </code>
 +CVS will tell you where it stashed the previous file, it usually starts with ".#" or similar. You can then run ''diff'' and see what the changes were, decide whether you need to find the lines that were previously around :823 and automatically or manually patch again, or not.))
  
-If the only two lines that differ are the ones you commented out with the above patch, just ''mv'' back ''.#acpi.c*'' to ''acpi.c'' because there were no changes. If the output of ''diff'' is more substantial, you might need to edit out the two lines by hand again; if they  still exist, and give us a shout so we can also update this tutorial. +To update the source tree on ''-current'', run:
- +
-=== Download the upgrade === +
-Fetch the release you are upgrading to, but without rebooting and installing automatically.  +
- +
-On ''-current'' this will be: +
-<code> +
-# sysupgrade -ns +
-</code>  +
- +
-On ''-stable'' this will be:+
 <code> <code>
-# sysupgrade -n+$ cd /usr/src 
 +$ cvs -q up -Pd -A
 </code> </code>
 +**NB**: On ''-stable'' you want to use '' -rOPENBSD_7_7'' as the last parameter instead of "-A". 
  
-Sysupgrade will download the new files for the download, you will find then under ''/home/_sysupgrade''. +==== 3. Re-compile the GENERIC.MP Kernel ==== 
- +See above, but run ''# make clean'' before compiling and **do not** run ''# make install'' at the end:
-=== Make and install the Ramdisk === +
-To build ''bsd.rd'', follow the instructions for building as above, but instead of ''GENERIC.MP'' you need to build build ''RAMDISK''.+
 <code> <code>
-$ doas -s +# cd /sys/arch/amd64/compile/GENERIC.MP/ 
-# cd /sys/arch/amd64/compile/RAMDISK+# make clean
 # make obj # make obj
 # make config # make config
 # make # make
-[...eventually...] 
-ctfstrip -S -o bsd bsd.gdb 
-# install -bp /sys/arch/amd64/compile/RAMDISK/obj/bsd /bsd.hax 
 </code> </code>
 +Your newly compiled kernel file, ''bsd.gdb'' will be in the symlinked ''obj'' directory. The symlink points to ''/usr/obj/sys/arch/amd64/compile/GENERIC.MP/bsd.gdb''.
  
-This will give you a "bsd.hax" ramdisk that you can boot to on next reboot. But don't just reboot yet.+Now we have: 
 +  * The latest update files stored away safely  
 +  * The latest kernel, compiled with our own patch
  
-=== Make and install the patched kernel again ===+So it is time to move on to the installation.
  
-Before rebooting, you need to re-compile ''bsd.mp'' and put it ''/home/_sysupgrade'':+==== 4. Manual installation ==== 
 +This follows closely the official [[https://www.openbsd.org/faq/upgrade77.html#NoInstKern|manual installation guide]], but diverges for the installation of the kernel.
  
 +=== 4.a. Make sure you have done all the preparation in the official guide ===
 +Did you?
 +
 +=== 4.b Install the newly compiled kernel ===
 +We did not run ''make install'' after compiling because we are going to do this little dance as suggested:
 <code> <code>
-$ doas -s +# cd /usr/update 
-# cd /sys/arch/amd64/compile/GENERIC.MP +# ln -f /bsd /obsd  
-# make obj +# cp /usr/obj/sys/arch/amd64/compile/GENERIC.MP/bsd.gdb /nbsd && mv /nbsd /bsd 
-# make config +# cp bsd.rd / 
-# make +# cp bsd /bsd.sp # You might not even have this file, relatively safe to skip this last one if you do not intend to run in single-processor mode
-[...eventually...] +
-ctfstrip -S -o bsd bsd.gdb +
-# install -bp /sys/arch/amd64/compile/GENERIC.MP/obj/bsd /home/_sysupgrade/bsd.mp+
 </code> </code>
  
-Reboot... Done!+=== 4.c follow the rest of the Manual Install Process === 
 +Follow closely the linked manual installation guide, and continue the process: Enable KARL; Install new userland. Reboot. Run MAKEDEV,  update the boot loader, run ''sysmerge'' and ''fw_update''. 
 + 
 +DONE!